safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Fri, 03 Feb 2023 02:57:49 +0100
changeset 50619 2704dc40cf10
parent 50618 17a86f650059
child 50620 26e63204c31e
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/debugcommands.py
--- a/mercurial/debugcommands.py	Fri Feb 03 01:05:41 2023 +0100
+++ b/mercurial/debugcommands.py	Fri Feb 03 02:57:49 2023 +0100
@@ -1718,7 +1718,7 @@
     if fm.isplain():
 
         def formatvalue(value):
-            if util.safehasattr(value, b'startswith'):
+            if util.safehasattr(value, 'startswith'):
                 return value
             if value:
                 return b'yes'