Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
bundle2: comment to clarify why the handler call is where it is
authorPierre-Yves David <pierre-yves.david@fb.com>
Fri, 11 Apr 2014 16:43:01 -0400
changeset 21004 27ab4b8d2503
parent 21003 0f7e01e0c06f
child 21005 3d38ebb586fe
bundle2: comment to clarify why the handler call is where it is The reason why it is here is not obvious. I'm the one who wrote it there in the first place and almost moved it 2 weeks later.
mercurial/bundle2.py file | annotate | diff | comparison | revisions 
--- a/mercurial/bundle2.py	Sat Apr 12 00:53:15 2014 -0400
+++ b/mercurial/bundle2.py	Fri Apr 11 16:43:01 2014 -0400
@@ -305,6 +305,11 @@
                 # todo:
                 # - consume the part once we use streaming
                 continue
+
+            # handler is called outside the above try block so that we don't
+            # risk catching KeyErrors from anything other than the
+            # parthandlermapping lookup (any KeyError raised by handler()
+            # itself represents a defect of a different variety).
             handler(op, part)
     except Exception:
         for part in iterparts:
Mercurial