Mercurial > hg
changeset 31816:2a865df042b7
check-code: update test IP address enforcement checks
Instead of mentioning 127.0.0.1, we should use $LOCALIP. Anytime
$LOCALIP appears in output, we should make sure we use (glob) on that
line of output so that weird environments that do remapping jiggery
pokery (such as our FreeBSD buildbot that's in a jail) don't get
spurious test failures.
| author | Augie Fackler <augie@google.com> |
|---|---|
| date | Mon, 03 Apr 2017 18:58:00 -0400 |
| parents | 7937dabb5447 |
| children | 07edd8c2f59a |
| files | contrib/check-code.py |
| diffstat | 1 files changed, 4 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/contrib/check-code.py Mon Apr 03 18:56:44 2017 -0400 +++ b/contrib/check-code.py Mon Apr 03 18:58:00 2017 -0400 @@ -190,8 +190,10 @@ (r'^ .*: largefile \S+ not available from file:.*/.*[^)]$', winglobmsg), (r'^ .*file://\$TESTTMP', 'write "file:/*/$TESTTMP" + (glob) to match on windows too'), - (r'^ [^$>].*27\.0\.0\.1.*[^)]$', - 'use (glob) to match localhost IP on hosts without 127.0.0.1 too'), + (r'^ [^$>].*27\.0\.0\.1', + 'use $LOCALIP not an explicit loopback address'), + (r'^ [^$>].*\$LOCALIP.*[^)]$', + 'mark $LOCALIP output lines with (glob) to help tests in BSD jails'), (r'^ (cat|find): .*: No such file or directory', 'use test -f to test for file existence'), (r'^ diff -[^ -]*p',