setup: preserve version part after the "+" on Windows stable
authorPierre-Yves David <pierre-yves.david@octobus.net>
Wed, 13 Nov 2024 21:17:46 +0100
branchstable
changeset 52247 309f58964a9e
parent 52246 124c944b71b2
child 52248 084e7ae69ae4
setup: preserve version part after the "+" on Windows Code introduced in early 2010 (fb203201ce30) was dropping that part after "+". The rational is to preserve version on the format w.x.y.z where each part is a number. However we have not been using that format for a while (e.g. the rc suffix) and nobody reported any fire. So I am assuming that this code serve no purpose and I am dropping it. We can reintroduce a newer version of it (that would actually achieve its purpose) in the future if needed.
setup.py
--- a/setup.py	Wed Nov 13 16:13:28 2024 +0100
+++ b/setup.py	Wed Nov 13 21:17:46 2024 +0100
@@ -1833,11 +1833,6 @@
 if os.environ.get('PYOXIDIZER'):
     hgbuild.sub_commands.insert(0, ('build_hgextindex', None))
 
-if os.name == 'nt':
-    # Windows binary file versions for exe/dll files must have the
-    # form W.X.Y.Z, where W,X,Y,Z are numbers in the range 0..65535
-    setupversion = setupversion.split(r'+', 1)[0]
-
 setup(
     version=setupversion,
     long_description=(