check-code: do not abort on an unreadable file, only report this stable
authorSimon Heimberg <simohe@besonet.ch>
Mon, 22 Jul 2013 10:04:45 +0200
branchstable
changeset 19494 3119dc155ac2
parent 19493 ca76e77dd663
child 19495 9aee3d014394
check-code: do not abort on an unreadable file, only report this
contrib/check-code.py
tests/test-check-code.t
--- a/contrib/check-code.py	Thu Jul 25 00:54:49 2013 -0500
+++ b/contrib/check-code.py	Mon Jul 22 10:04:45 2013 +0200
@@ -407,7 +407,11 @@
                 print "Skipping %s for %s it doesn't match %s" % (
                        name, match, f)
             continue
-        fp = open(f)
+        try:
+            fp = open(f)
+        except IOError, e:
+            print "Skipping %s, %s" % (f, str(e).split(':', 1)[0])
+            continue
         pre = post = fp.read()
         fp.close()
         if "no-" "check-code" in pre:
--- a/tests/test-check-code.t	Thu Jul 25 00:54:49 2013 -0500
+++ b/tests/test-check-code.t	Mon Jul 22 10:04:45 2013 +0200
@@ -187,8 +187,10 @@
   > # this next line is okay
   > raise SomeException(arg1, arg2)
   > EOF
-  $ "$check_code" raise-format.py
+  $ "$check_code" not-existing.py raise-format.py
+  Skipping*not-existing.py* (glob)
   raise-format.py:1:
    > raise SomeException, message
    don't use old-style two-argument raise, use Exception(message)
   [1]
+