Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: fix the error message about 'class foo():'
authorPierre-Yves David <pierre-yves.david@fb.com>
Sun, 17 May 2015 17:40:26 -0700
changeset 25140 317333e0793c
parent 25139 6d3079e9b53f
child 25141 3ea8d6b5e665
check-code: fix the error message about 'class foo():' Using 'classs foo():' result in old style object instead of new style object. We do not want old style object so this check is unrelated to 2.4.
contrib/check-code.py file | annotate | diff | comparison | revisions
tests/test-check-code.t file | annotate | diff | comparison | revisions 
--- a/contrib/check-code.py	Sun May 17 17:36:26 2015 -0700
+++ b/contrib/check-code.py	Sun May 17 17:40:26 2015 -0700
@@ -234,7 +234,7 @@
      "linebreak after :"),
     (r'class\s[^( \n]+:', "old-style class, use class foo(object)"),
     (r'class\s[^( \n]+\(\):',
-     "class foo() not available in Python 2.4, use class foo(object)"),
+     "class foo() creates old style object, use class foo(object)"),
     (r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist
                             if k not in ('print', 'exec')),
      "Python keyword is not a function"),
--- a/tests/test-check-code.t	Sun May 17 17:36:26 2015 -0700
+++ b/tests/test-check-code.t	Sun May 17 17:40:26 2015 -0700
@@ -115,7 +115,7 @@
    old-style class, use class foo(object)
   ./classstyle.py:7:
    > class empty():
-   class foo() not available in Python 2.4, use class foo(object)
+   class foo() creates old style object, use class foo(object)
   [1]
   $ cat > python3-compat.py << EOF
   > foo <> bar
Mercurial