Mercurial > hg

changeset 19031:341083b02d1b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: add check for lock release order
author Matt Mackall <mpm@selenic.com>
date Wed, 17 Apr 2013 14:38:02 -0500
parents 48d6f436363e
children 7d31f2e42a8a
files contrib/check-code.py
diffstat 1 files changed, 1 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/contrib/check-code.py	Wed Apr 17 12:57:26 2013 -0500
+++ b/contrib/check-code.py	Wed Apr 17 14:38:02 2013 -0500
@@ -224,6 +224,7 @@
     (r':\n(    )*( ){1,3}[^ ]', "must indent 4 spaces"),
     (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
      "missing _() in ui message (use () to hide false-positives)"),
+    (r'release\(.*wlock, .*lock\)', "wrong lock release order"),
   ],
   # warnings
   [