Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
bisect: simplify conditional in 'check_state'
authorPierre-Yves David <pierre-yves.david@ens-lyon.org>
Wed, 24 Aug 2016 04:23:13 +0200
changeset 30125 3528117c7b4e
parent 30124 0aea706060cc
child 30126 755730fc1e48
bisect: simplify conditional in 'check_state' Now that extra code about "updating" flag have been removed, we can simplify the condition flow and remove a level.
mercurial/commands.py file | annotate | diff | comparison | revisions 
--- a/mercurial/commands.py	Wed Aug 24 04:22:40 2016 +0200
+++ b/mercurial/commands.py	Wed Aug 24 04:23:13 2016 +0200
@@ -836,12 +836,12 @@
     Returns 0 on success.
     """
     def checkstate(state):
-        if not state['good'] or not state['bad']:
-            if not state['good']:
-                raise error.Abort(_('cannot bisect (no known good revisions)'))
-            else:
-                raise error.Abort(_('cannot bisect (no known bad revisions)'))
-        return True
+        if state['good'] and state['bad']:
+            return True
+        if not state['good']:
+            raise error.Abort(_('cannot bisect (no known good revisions)'))
+        else:
+            raise error.Abort(_('cannot bisect (no known bad revisions)'))
 
     # backward compatibility
     if rev in "good bad reset init".split():
Mercurial