Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
revset: use 'next()' to detect end of iteration in 'last'
authorPierre-Yves David <pierre-yves.david@fb.com>
Sun, 17 May 2015 18:00:38 -0700
changeset 25145 3553163bb736
parent 25144 81a395447b34
child 25146 f542a2c89b60
revset: use 'next()' to detect end of iteration in 'last' The 'next()' built-in can return a default value, allow to get rid of the confusing try/except code flow.
mercurial/revset.py file | annotate | diff | comparison | revisions 
--- a/mercurial/revset.py	Sun May 17 17:58:39 2015 -0700
+++ b/mercurial/revset.py	Sun May 17 18:00:38 2015 -0700
@@ -1172,12 +1172,11 @@
     result = []
     it = iter(os)
     for x in xrange(lim):
-        try:
-            y = it.next()
-            if y in ss:
-                result.append(y)
-        except (StopIteration):
+        y = next(it, None)
+        if y is None:
             break
+        elif y in ss:
+            result.append(y)
     return baseset(result)
 
 def maxrev(repo, subset, x):
Mercurial