flagprocessors: move _flagserrorclass attribute on revlog & co
authorPierre-Yves David <pierre-yves.david@octobus.net>
Sat, 07 Sep 2019 00:26:15 +0200
changeset 42994 3674797ae8b9
parent 42993 01304095256c
child 42995 73288e7abe9b
flagprocessors: move _flagserrorclass attribute on revlog & co This is a small duplication, and the last bit we need to get rid of the mixin. Honestly, I am not fan of that class attribute and it mostly exist to accomodate The simple-storage whose usage of flag processors is dumbious and that is currently dead code anyway. However I don't want to be pulled into futher unrelated cleaning so it is a small price to pay. Differential Revision: https://phab.mercurial-scm.org/D6822
hgext/remotefilelog/remotefilelog.py
mercurial/revlog.py
mercurial/revlogutils/flagutil.py
--- a/hgext/remotefilelog/remotefilelog.py	Sat Sep 07 00:22:38 2019 +0200
+++ b/hgext/remotefilelog/remotefilelog.py	Sat Sep 07 00:26:15 2019 +0200
@@ -50,6 +50,7 @@
 class remotefilelog(flagutil.flagprocessorsmixin):
 
     _generaldelta = True
+    _flagserrorclass = error.RevlogError
 
     def __init__(self, opener, path, repo):
         self.opener = opener
--- a/mercurial/revlog.py	Sat Sep 07 00:22:38 2019 +0200
+++ b/mercurial/revlog.py	Sat Sep 07 00:26:15 2019 +0200
@@ -298,6 +298,9 @@
     If `upperboundcomp` is not None, this is the expected maximal gain from
     compression for the data content.
     """
+
+    _flagserrorclass = error.RevlogError
+
     def __init__(self, opener, indexfile, datafile=None, checkambig=False,
                  mmaplargeindex=False, censorable=False,
                  upperboundcomp=None):
--- a/mercurial/revlogutils/flagutil.py	Sat Sep 07 00:22:38 2019 +0200
+++ b/mercurial/revlogutils/flagutil.py	Sat Sep 07 00:26:15 2019 +0200
@@ -87,8 +87,6 @@
     See the documentation of the ``_processflags`` method for details.
     """
 
-    _flagserrorclass = error.RevlogError
-
 def processflagswrite(revlog, text, flags, sidedata):
     """Inspect revision data flags and applies write transformations defined
     by registered flag processors.