py3: handle keyword arguments correctly in hgext/acl.py
authorPulkit Goyal <pulkit@yandex-team.ru>
Tue, 04 Sep 2018 17:19:30 +0300
changeset 39427 3694c9aaf5e4
parent 39426 34fe76b31ca4
child 39428 cbfab495dbcf
py3: handle keyword arguments correctly in hgext/acl.py The keys of keyword arguments on python 3 should be str, so when we try to get some key from them, we must make sure we are using str. # skip-blame because just b'' prefix Differential Revision: https://phab.mercurial-scm.org/D4455
hgext/acl.py
--- a/hgext/acl.py	Tue Sep 04 17:16:29 2018 +0300
+++ b/hgext/acl.py	Tue Sep 04 17:19:30 2018 +0300
@@ -375,9 +375,9 @@
         _txnhook(ui, repo, hooktype, node, source, user, **kwargs)
 
 def _pkhook(ui, repo, hooktype, node, source, user, **kwargs):
-    if kwargs['namespace'] == 'bookmarks':
-        bookmark = kwargs['key']
-        ctx = kwargs['new']
+    if kwargs[r'namespace'] == 'bookmarks':
+        bookmark = kwargs[r'key']
+        ctx = kwargs[r'new']
         allowbookmarks = buildmatch(ui, None, user, 'acl.allow.bookmarks')
         denybookmarks = buildmatch(ui, None, user, 'acl.deny.bookmarks')