Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
exchange: simplify unbundle locking using context managers
authorMartin von Zweigbergk <martinvonz@google.com>
Fri, 28 Jul 2017 22:04:27 -0700
changeset 33794 389f7b17ffb3
parent 33793 bbbbd3c30bfc
child 33795 cf300c1ad7bf
exchange: simplify unbundle locking using context managers Differential Revision: https://phab.mercurial-scm.org/D393
mercurial/exchange.py file | annotate | diff | comparison | revisions 
--- a/mercurial/exchange.py	Fri Jul 28 22:42:10 2017 -0700
+++ b/mercurial/exchange.py	Fri Jul 28 22:04:27 2017 -0700
@@ -459,7 +459,9 @@
         msg = 'cannot lock source repository: %s\n' % err
         pushop.ui.debug(msg)
 
-    try:
+    with wlock or util.nullcontextmanager(), \
+            lock or util.nullcontextmanager(), \
+            pushop.trmanager or util.nullcontextmanager():
         pushop.repo.checkpush(pushop)
         _pushdiscovery(pushop)
         if not _forcebundle1(pushop):
@@ -469,16 +471,6 @@
         _pushobsolete(pushop)
         _pushbookmark(pushop)
 
-        if pushop.trmanager:
-            pushop.trmanager.close()
-    finally:
-        if pushop.trmanager:
-            pushop.trmanager.release()
-        if lock is not None:
-            lock.release()
-        if wlock is not None:
-            wlock.release()
-
     return pushop
 
 # list of steps to perform discovery before push
Mercurial