parsers: suppress warning of signed and unsigned comparison at nt_init
authorYuya Nishihara <yuya@tcha.org>
Sun, 18 Oct 2015 09:05:04 +0900
changeset 26775 3c259710737c
parent 26774 04ab2348efd1
child 26776 f69c79395fb7
parsers: suppress warning of signed and unsigned comparison at nt_init Spotted by CC=clang CFLAGS='-Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wshorten-64-to-32': mercurial/parsers.c:1580:24: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and 'unsigned long' [-Wsign-compare] if (self->raw_length > INT_MAX / sizeof(nodetree)) {
mercurial/parsers.c
--- a/mercurial/parsers.c	Sat Oct 17 23:14:13 2015 +0900
+++ b/mercurial/parsers.c	Sun Oct 18 09:05:04 2015 +0900
@@ -1577,7 +1577,7 @@
 static int nt_init(indexObject *self)
 {
 	if (self->nt == NULL) {
-		if (self->raw_length > INT_MAX / sizeof(nodetree)) {
+		if ((size_t)self->raw_length > INT_MAX / sizeof(nodetree)) {
 			PyErr_SetString(PyExc_ValueError, "overflow in nt_init");
 			return -1;
 		}