parsers: use PyTuple_Pack instead of manual list-filling
authorBryan O'Sullivan <bos@serpentine.com>
Thu, 17 Dec 2015 13:07:34 -0800
changeset 27410 41127e875758
parent 27409 32bea9daa877
child 27411 c84a07530040
parsers: use PyTuple_Pack instead of manual list-filling Suggested by Yuya.
mercurial/parsers.c
--- a/mercurial/parsers.c	Thu Dec 17 15:23:36 2015 -0800
+++ b/mercurial/parsers.c	Thu Dec 17 13:07:34 2015 -0800
@@ -1351,15 +1351,7 @@
 			goto release;
 		PyList_SET_ITEM(phaseslist, i, phaseval);
 	}
-	ret = PyList_New(2);
-	if (ret == NULL)
-		goto release;
-
-	PyList_SET_ITEM(ret, 0, phaseslist);
-	PyList_SET_ITEM(ret, 1, phasessetlist);
-	/* We don't release phaseslist and phasessetlist as we return them to
-	 * python */
-	goto done;
+	ret = PyTuple_Pack(2, phaseslist, phasessetlist);
 
 release:
 	Py_XDECREF(phaseslist);