Mercurial > hg

changeset 27014:4223fc58f952

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
rebase: refactoring to avoid repetition of expression This patch removes the repetition of "(revignored, revprecursor, revpruned)" and replaces its occurences with the more legible "revskipped".
author Laurent Charignon <lcharignon@fb.com>
date Wed, 18 Nov 2015 15:58:06 -0800
parents e97132eb841c
children 341cb90ffd18
files hgext/rebase.py
diffstat 1 files changed, 3 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/hgext/rebase.py	Wed Nov 18 16:06:00 2015 -0800
+++ b/hgext/rebase.py	Wed Nov 18 15:58:06 2015 -0800
@@ -34,6 +34,7 @@
 revprecursor = -4
 # plain prune (no successor)
 revpruned = -5
+revskipped = (revignored, revprecursor, revpruned)
 
 cmdtable = {}
 command = cmdutil.command(cmdtable)
@@ -681,7 +682,7 @@
     elif p1n in state:
         if state[p1n] == nullmerge:
             p1 = target
-        elif state[p1n] in (revignored, revprecursor, revpruned):
+        elif state[p1n] in revskipped:
             p1 = nearestrebased(repo, p1n, state)
             if p1 is None:
                 p1 = target
@@ -697,7 +698,7 @@
         if p2n in state:
             if p1 == target: # p1n in targetancestors or external
                 p1 = state[p2n]
-            elif state[p2n] in (revignored, revprecursor, revpruned):
+            elif state[p2n] in revskipped:
                 p2 = nearestrebased(repo, p2n, state)
                 if p2 is None:
                     # no ancestors rebased yet, detach