push: add tests for unsafe ssh url (SEC) stable
authorSean Farley <sean@farley.io>
Mon, 31 Jul 2017 14:40:28 -0700
branchstable
changeset 33655 48d520fdf880
parent 33654 0ee42a0df5be
child 33656 475af2f89636
push: add tests for unsafe ssh url (SEC)
tests/test-push.t
--- a/tests/test-push.t	Fri Jul 28 16:47:32 2017 -0700
+++ b/tests/test-push.t	Mon Jul 31 14:40:28 2017 -0700
@@ -316,3 +316,22 @@
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
+
+SEC: check for unsafe ssh url
+
+  $ hg -R test-revflag push 'ssh://-oProxyCommand=touch${IFS}owned/path'
+  pushing to ssh://-oProxyCommand%3Dtouch%24%7BIFS%7Downed/path
+  abort: potentially unsafe url: 'ssh://-oProxyCommand=touch${IFS}owned/path'
+  [255]
+  $ hg -R test-revflag push 'ssh://%2DoProxyCommand=touch${IFS}owned/path'
+  pushing to ssh://-oProxyCommand%3Dtouch%24%7BIFS%7Downed/path
+  abort: potentially unsafe url: 'ssh://-oProxyCommand=touch${IFS}owned/path'
+  [255]
+  $ hg -R test-revflag push 'ssh://fakehost|shellcommand/path'
+  pushing to ssh://fakehost%7Cshellcommand/path
+  abort: potentially unsafe url: 'ssh://fakehost|shellcommand/path'
+  [255]
+  $ hg -R test-revflag push 'ssh://fakehost%7Cshellcommand/path'
+  pushing to ssh://fakehost%7Cshellcommand/path
+  abort: potentially unsafe url: 'ssh://fakehost|shellcommand/path'
+  [255]