Mercurial > hg
changeset 44890:4942c1bdd080
sslutil: add FIXME about supportedprotocols possibly containing too many items
| author | Manuel Jacob <me@manueljacob.de> |
|---|---|
| date | Sun, 31 May 2020 11:41:03 +0200 |
| parents | ceb7318013d5 |
| children | abcd6db1f2cc |
| files | mercurial/sslutil.py |
| diffstat | 1 files changed, 7 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/sslutil.py Sun May 31 10:47:38 2020 +0200 +++ b/mercurial/sslutil.py Sun May 31 11:41:03 2020 +0200 @@ -46,6 +46,13 @@ # TLS 1.1 and 1.2 may not be supported if the OpenSSL Python is compiled # against doesn't support them. +# FIXME: Since CPython commit 6e8cda91d92da72800d891b2fc2073ecbc134d98 +# individual TLS versions can be turned on and off, and the +# ssl.PROTOCOL_TLSv1_* constants are always defined. +# This means that, on unusual configurations, the following dict may contain +# too many entries. A proper fix would be to check ssl.HAS_TLSv* where +# available (Python 3.7+). Before that, this module should be proofed against +# all possible combinations. supportedprotocols = {b'tls1.0'} if util.safehasattr(ssl, b'PROTOCOL_TLSv1_1'): supportedprotocols.add(b'tls1.1')