Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
obsolete: use context manager for lock in pushmarker()
authorMartin von Zweigbergk <martinvonz@google.com>
Wed, 10 Jan 2018 10:32:16 -0800
changeset 35573 5574629d5d45
parent 35572 8b729856ca03
child 35574 09285733ad71
obsolete: use context manager for lock in pushmarker() Differential Revision: https://phab.mercurial-scm.org/D1836
mercurial/obsolete.py file | annotate | diff | comparison | revisions 
--- a/mercurial/obsolete.py	Wed Jan 10 10:30:51 2018 -0800
+++ b/mercurial/obsolete.py	Wed Jan 10 10:32:16 2018 -0800
@@ -838,8 +838,7 @@
         repo.ui.warn(_('unexpected old value for %r') % key)
         return False
     data = util.b85decode(new)
-    lock = repo.lock()
-    try:
+    with repo.lock():
         tr = repo.transaction('pushkey: obsolete markers')
         try:
             repo.obsstore.mergemarkers(tr, data)
@@ -848,8 +847,6 @@
             return True
         finally:
             tr.release()
-    finally:
-        lock.release()
 
 # keep compatibility for the 4.3 cycle
 def allprecursors(obsstore, nodes, ignoreflags=0):
Mercurial