Mercurial > hg

changeset 48945:55d132525155

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: remove ban on old-style classes In Python 3, `class foo:` is equivalent to `class foo(object):`. So we can allow the former form now. Differential Revision: https://phab.mercurial-scm.org/D12351
author Gregory Szorc <gregory.szorc@gmail.com>
date Mon, 21 Feb 2022 13:03:43 -0700
parents fe3303436b79
children 642e31cb55f0
files contrib/check-code.py tests/test-contrib-check-code.t
diffstat 2 files changed, 0 insertions(+), 16 deletions(-) [+]
line wrap: on
line diff
--- a/contrib/check-code.py	Mon Feb 21 12:46:27 2022 -0700
+++ b/contrib/check-code.py	Mon Feb 21 13:03:43 2022 -0700
@@ -343,16 +343,6 @@
             "linebreak after :",
         ),
         (
-            r'class\s[^( \n]+:',
-            "old-style class, use class foo(object)",
-            r'#.*old-style',
-        ),
-        (
-            r'class\s[^( \n]+\(\):',
-            "class foo() creates old style object, use class foo(object)",
-            r'#.*old-style',
-        ),
-        (
             r'\b(%s)\('
             % '|'.join(k for k in keyword.kwlist if k not in ('print', 'exec')),
             "Python keyword is not a function",
--- a/tests/test-contrib-check-code.t	Mon Feb 21 12:46:27 2022 -0700
+++ b/tests/test-contrib-check-code.t	Mon Feb 21 13:03:43 2022 -0700
@@ -51,12 +51,6 @@
   ./quote.py:5:
    > '"""', 42+1, """and
    missing whitespace in expression
-  ./classstyle.py:4:
-   > class oldstyle_class:
-   old-style class, use class foo(object)
-  ./classstyle.py:7:
-   > class empty():
-   class foo() creates old style object, use class foo(object)
   [1]
   $ cat > python3-compat.py << NO_CHECK_EOF
   > foo <> bar