changeset 602:56d81b303656

Various HTML cleanups

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Various HTML cleanups

From: Edouard Gomez <[e-mail]>

Cleaned up the changeset summary table differentiating title cells
from data cells using th and td. Added semantic classes.

Changed the big pre tag into a div that mimics pre tag style
(that is monospace font and white space preformated). This is
required because pre is an inline element, and thus cannot
be the parent of block elements as div (diffblock). I replaced
all these div blocks by a series ul lists as patches can be
seen as lists of changes in versioned files.

If someone has a better semantic to propose, i'd be pleased he
drops me an email about this patch.

- --

Cleaned up the filediff summary table differentiating title cells
from data cells using th and td. Added semantic classes.

- --

Keep style unchanged for changeset template

As promised no changes in style. This one got through my eyes
+ brain checking... sorry.

manifest hash: 68dd5c1ac71aa6a5932fb209d48df5fc0c78643b
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCyLwfywK+sNU5EO8RAtE9AJ0cxl80eF3zpBWLn8OkoSs7dkZOTgCgtYto
j7T/iRk0Hq4Q0mjdos7FvYU=
=KOP2
-----END PGP SIGNATURE-----

--- a/templates/changeset.tmpl	Sun Jul 03 20:21:37 2005 -0800
+++ b/templates/changeset.tmpl	Sun Jul 03 20:33:35 2005 -0800
@@ -12,34 +12,38 @@
 
 <h2>changeset: #desc|escape|firstline#</h2>
 
-<table>
+<table id="changesetEntry">
 <tr>
- <td class="metatag">changeset #rev#:</td>
- <td><a href="?cmd=changeset;node=#node#">#node|short#</a></td></tr>
+ <th class="changeset">changeset #rev#:</th>
+ <td class="changeset"><a href="?cmd=changeset;node=#node#">#node|short#</a></td>
+</tr>
 #parent#
 #changesettag#
 <tr>
- <td class="metatag">manifest:</td>
- <td><a href="?cmd=manifest;manifest=#manifest#;path=/">#manifest|short#</a></td></tr>
+ <th class="manifest">manifest:</th>
+ <td class="manifest"><a href="?cmd=manifest;manifest=#manifest#;path=/">#manifest|short#</a></td>
+</tr>
 <tr>
- <td class="metatag">author:</td>
- <td>#author|obfuscate#</td></tr>
+ <th class="author">author:</th>
+ <td class="author">#author|obfuscate#</td>
+</tr>
 <tr>
- <td class="metatag">date:</td>
- <td>#date|date# (#date|age# ago)</td></tr>
+ <th class="date">date:</th>
+ <td class="date">#date|date# (#date|age# ago)</td></tr>
 <tr>
- <td class="metatag" valign="top">files:</td>
- <td>#files#</td></tr>
+ <th class="files">files:</th>
+ <td class="files">#files#</td></tr>
 <tr>
- <td class="metatag" valign="top">description:</td>
- <td>#desc|escape|addbreaks#</td></tr>
+ <th class="description">description:</th>
+ <td class="description">#desc|escape|addbreaks#</td>
+</tr>
 </table>
 
-<pre>
+<div id="changesetDiff" class="pre">
 #diff#
-</pre>
+</div>
 
 </body>
-</html
+</html>
 
 

--- a/templates/filediff.tmpl	Sun Jul 03 20:21:37 2005 -0800
+++ b/templates/filediff.tmpl	Sun Jul 03 20:33:35 2005 -0800
@@ -15,16 +15,17 @@
 
 <h2>#file#</h2>
 
-<table>
+<table id="filediffEntry">
 <tr>
- <td class="metatag">revision #rev#:</td>
- <td><a href="?cmd=changeset;node=#node#">#node|short#</a></td></tr>
+ <th class="revision">revision #rev#:</th>
+ <td class="revision"><a href="?cmd=changeset;node=#node#">#node|short#</a></td>
+</tr>
 #parent#
 </table>
 
-<pre>
+<div id="fileDiff" class="pre">
 #diff#
-</pre>
+</div>
 
 #footer#
 

--- a/templates/header.tmpl	Sun Jul 03 20:21:37 2005 -0800
+++ b/templates/header.tmpl	Sun Jul 03 20:33:35 2005 -0800
@@ -26,6 +26,9 @@
   text-align: right; 
 }
 
+/* Common */
+.pre { font-family: monospace; white-space: pre; }
+
 /* Changelog entries */
 .changelogEntry { width: 100%; }
 .changelogEntry th { font-weight: normal; text-align: right; vertical-align: top; width: 15%;}
@@ -36,5 +39,16 @@
 #tagEntries { list-style: none; margin: 0; padding: 0; }
 #tagEntries .tagEntry { list-style: none; margin: 0; padding: 0; }
 #tagEntries .tagEntry span.node { font-family: monospace; }
+
+/* Changeset entry */
+#changesetEntry { }
+#changesetEntry th { font-weight: normal; background-color: #888; color: #fff; text-align: right; }
+#changesetEntry th.files, #changesetEntry th.description { vertical-align: top; }
+#changesetDiff ul, #changesetDiff li { list-style: none; margin: 0; padding: 0; }
+
+/* File diff view */
+#filediffEntry { }
+#filediffEntry th { font-weight: normal; background-color: #888; color: #fff; text-align: right; }
+#fileDiff ul, #fileDiff li { list-style: none; margin: 0; padding: 0; }
 -->
 </style>

--- a/templates/map	Sun Jul 03 20:21:37 2005 -0800
+++ b/templates/map	Sun Jul 03 20:33:35 2005 -0800
@@ -19,18 +19,18 @@
 fileline = "<div class="parity#parity#"><span class="lineno">#linenumber# </span>#line|escape#</div>"
 filelogentry = filelogentry.tmpl
 annotateline = "<tr class="parity#parity#"><td class="annotate"><a href="?cmd=changeset;node=#node#">#author|obfuscate#@#rev#</a></td><td><pre>#line|escape#</pre></td></tr>"
-difflineplus = "<span class="plusline">#line|escape#</span>"
-difflineminus = "<span class="minusline">#line|escape#</span>"
-difflineat = "<span class="atline">#line|escape#</span>"
-diffline = "#line|escape#"
-changelogparent = "<tr><th class="parent">parent #rev#:</th><td><a href="?cmd=changeset;node=#node#">#node|short#</a></td></tr>"
-changesetparent = "<tr><td class="metatag">parent #rev#:</td><td><a href="?cmd=changeset;node=#node#">#node|short#</a></td></tr>"
+difflineplus = "<li class="plusline">#line|escape#</li>"
+difflineminus = "<li class="minusline">#line|escape#</li>"
+difflineat = "<li class="atline">#line|escape#</li>"
+diffline = "<li>#line|escape#</li>"
+changelogparent = "<tr><th class="parent">parent #rev#:</th><td class="parent"><a href="?cmd=changeset;node=#node#">#node|short#</a></td></tr>"
+changesetparent = "<tr><th class="parent">parent #rev#:</th><td class="parent"><a href="?cmd=changeset;node=#node#">#node|short#</a></td></tr>"
 filerevparent = "<tr><td class="metatag">parent:</td><td><a href="?cmd=file;file=#file#;filenode=#node#">#node|short#</a></td></tr>"
 fileannotateparent = "<tr><td class="metatag">parent:</td><td><a href="?cmd=annotate;file=#file#;filenode=#node#">#node|short#</a></td></tr>"
 tags = tags.tmpl
 tagentry = "<li class="tagEntry parity#parity#"><span class="node">#node#</span> <a href="?cmd=changeset;node=#node#">#tag#</a></li>"
-diffblock = "<div class="parity#parity#">#lines#</div>"
-changelogtag = "<tr><td align="right">tag:&nbsp;</td><td>#tag#</td></tr>"
-changesettag = "<tr><td class="metatag">tag:&nbsp;</td><td>#tag#</td></tr>"
-filediffparent = "<tr><td class="metatag">parent #rev#:</td><td><a href="?cmd=changeset;node=#node#">#node|short#</a></td></tr>"
+diffblock = "<ul class="parity#parity#">#lines#</ul>"
+changelogtag = "<tr><th class="tag">tag:</th><td class="tag">#tag#</td></tr>"
+changesettag = "<tr><th class="tag">tag:</th><td class="tag">#tag#</td></tr>"
+filediffparent = "<tr><th class="parent">parent #rev#:</th><td class="parent"><a href="?cmd=changeset;node=#node#">#node|short#</a></td></tr>"
 filelogparent = "<tr><td align="right">parent #rev#:&nbsp;</td><td><a href="?cmd=file;file=#file#;filenode=#node#">#node|short#</a></td></tr>"