shortest: fix an off-by-1 when disambiguating against revnums
authorMartin von Zweigbergk <martinvonz@google.com>
Wed, 29 Aug 2018 15:49:11 -0700
changeset 39360 570fca90d556
parent 39359 bc0eb1dc6aae
child 39361 5ebfb7cc6f2c
shortest: fix an off-by-1 when disambiguating against revnums Revision "5" is an unambiguous hex prefix in a repo with 5 revisions; it's only "4" and lower that are ambiguous. Differential Revision: https://phab.mercurial-scm.org/D4420
mercurial/scmutil.py
--- a/mercurial/scmutil.py	Wed Aug 29 22:53:44 2018 -0400
+++ b/mercurial/scmutil.py	Wed Aug 29 15:49:11 2018 -0700
@@ -475,7 +475,7 @@
         # if we are a pure int, then starting with zero will not be
         # confused as a rev; or, obviously, if the int is larger
         # than the value of the tip rev
-        if prefix[0:1] == b'0' or i > len(repo):
+        if prefix[0:1] == b'0' or i >= len(repo):
             return False
         return True
     except ValueError: