Mercurial > hg
changeset 30004:5aaa3d6b7e92
log: drop outdated optimization to walk revisions in reverse order
Since revset is computed lazily, there would be no (or little) benefit to
reverse 'revs' temporarily.
| author | Yuya Nishihara <yuya@tcha.org> |
|---|---|
| date | Thu, 22 Sep 2016 20:59:24 +0900 |
| parents | 46825334f270 |
| children | dfd97e60044c |
| files | mercurial/cmdutil.py |
| diffstat | 1 files changed, 0 insertions(+), 10 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/cmdutil.py Thu Sep 22 20:53:53 2016 +0900 +++ b/mercurial/cmdutil.py Thu Sep 22 20:59:24 2016 +0900 @@ -2152,12 +2152,8 @@ if not (revs.isdescending() or revs.istopo()): revs.sort(reverse=True) if expr: - # Revset matchers often operate faster on revisions in changelog - # order, because most filters deal with the changelog. - revs.reverse() matcher = revset.match(repo.ui, expr, order=revset.followorder) revs = matcher(repo, revs) - revs.reverse() if limit is not None: limitedrevs = [] for idx, rev in enumerate(revs): @@ -2182,14 +2178,8 @@ return revset.baseset([]), None, None expr, filematcher = _makelogrevset(repo, pats, opts, revs) if expr: - # Revset matchers often operate faster on revisions in changelog - # order, because most filters deal with the changelog. - if not opts.get('rev'): - revs.reverse() matcher = revset.match(repo.ui, expr, order=revset.followorder) revs = matcher(repo, revs) - if not opts.get('rev'): - revs.reverse() if limit is not None: limitedrevs = [] for idx, r in enumerate(revs):