Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
narrow: replace filtering in list comprehension by set operations
authorMartin von Zweigbergk <martinvonz@google.com>
Tue, 23 Oct 2018 14:04:17 -0700
changeset 40438 5d8f291405e5
parent 40437 a0e7fa019290
child 40439 25f1c7bd649d
narrow: replace filtering in list comprehension by set operations I didn't think of this while reviewing the patch. Differential Revision: https://phab.mercurial-scm.org/D5188
hgext/narrow/narrowcommands.py file | annotate | diff | comparison | revisions 
--- a/hgext/narrow/narrowcommands.py	Tue Oct 23 19:20:22 2018 +0200
+++ b/hgext/narrow/narrowcommands.py	Tue Oct 23 14:04:17 2018 -0700
@@ -400,10 +400,10 @@
 
     # filter the user passed additions and deletions into actual additions and
     # deletions of excludes and includes
-    addedincludes = set([i for i in addedincludes if i not in oldincludes])
-    removedincludes = set([i for i in removedincludes if i in oldincludes])
-    addedexcludes = set([i for i in addedexcludes if i not in oldexcludes])
-    removedexcludes = set([i for i in removedexcludes if i in oldexcludes])
+    addedincludes -= oldincludes
+    removedincludes &= oldincludes
+    addedexcludes -= oldexcludes
+    removedexcludes &= oldexcludes
 
     widening = addedincludes or removedexcludes
     narrowing = removedincludes or addedexcludes
Mercurial