getlogrevs: remove user of baseset.append
authorPierre-Yves David <pierre-yves.david@fb.com>
Tue, 07 Oct 2014 00:04:16 -0700
changeset 22806 65ccc733d58e
parent 22805 e74245b79901
child 22807 cd43195ef876
getlogrevs: remove user of baseset.append A `baseset` has multiple cached results and will get even more in the future. Making it an object "populated once" like the other smartsets makes it both safer and simpler. The append method will be removed at some point.
mercurial/cmdutil.py
--- a/mercurial/cmdutil.py	Wed Oct 08 00:55:09 2014 -0700
+++ b/mercurial/cmdutil.py	Tue Oct 07 00:04:16 2014 -0700
@@ -1901,7 +1901,7 @@
             revs.sort(reverse=True)
     if limit is not None:
         count = 0
-        limitedrevs = revset.baseset([])
+        limitedrevs = []
         it = iter(revs)
         while count < limit:
             try:
@@ -1909,7 +1909,7 @@
             except (StopIteration):
                 break
             count += 1
-        revs = limitedrevs
+        revs = revset.baseset(limitedrevs)
 
     return revs, expr, filematcher