Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
color: rework conditional 'valideffect'
authorPierre-Yves David <pierre-yves.david@ens-lyon.org>
Thu, 22 Dec 2016 02:30:03 +0100
changeset 30970 683606a829e8
parent 30969 ddc80d1777a6
child 30971 bb6385882cfa
color: rework conditional 'valideffect' Not very important, but the full conditional is not that hard to follow and having it unified make the function role a bit clearer in my opinion.
mercurial/color.py file | annotate | diff | comparison | revisions 
--- a/mercurial/color.py	Thu Dec 22 02:26:50 2016 +0100
+++ b/mercurial/color.py	Thu Dec 22 02:30:03 2016 +0100
@@ -116,10 +116,6 @@
 
 def valideffect(effect):
     'Determine if the effect is valid or not.'
-    good = False
-    if not _terminfo_params and effect in _effects:
-        good = True
-    elif (effect in _terminfo_params
-          or effect[:-11] in _terminfo_params):
-        good = True
-    return good
+    return ((not _terminfo_params and effect in _effects)
+             or (effect in _terminfo_params
+                 or effect[:-11] in _terminfo_params))
Mercurial