revlog: pass node as an argument of addrevision
authorWojciech Lopata <lopek@fb.com>
Mon, 19 Aug 2013 11:25:23 -0700
changeset 19625 6a411a06cb1f
parent 19624 55749cb14d24
child 19626 cf6b086d64cc
revlog: pass node as an argument of addrevision This change will allow revlog subclasses that override 'checkhash' method to use custom strategy of computing nodeids without overriding 'addrevision' method. In particular this change is necessary to implement manifest compression.
mercurial/revlog.py
--- a/mercurial/revlog.py	Mon Aug 19 11:06:38 2013 -0700
+++ b/mercurial/revlog.py	Mon Aug 19 11:25:23 2013 -0700
@@ -993,7 +993,8 @@
         tr.replace(self.indexfile, trindex * self._io.size)
         self._chunkclear()
 
-    def addrevision(self, text, transaction, link, p1, p2, cachedelta=None):
+    def addrevision(self, text, transaction, link, p1, p2, cachedelta=None,
+                    node=None):
         """add a revision to the log
 
         text - the revision data to add
@@ -1001,11 +1002,14 @@
         link - the linkrev data to add
         p1, p2 - the parent nodeids of the revision
         cachedelta - an optional precomputed delta
+        node - nodeid of revision; typically node is not specified, and it is
+            computed by default as hash(text, p1, p2), however subclasses might
+            use different hashing method (and override checkhash() in such case)
         """
         if link == nullrev:
             raise RevlogError(_("attempted to add linkrev -1 to %s")
                               % self.indexfile)
-        node = hash(text, p1, p2)
+        node = node or hash(text, p1, p2)
         if node in self.nodemap:
             return node