changeset 31825:6c7a58d3ca5d

test-check-code: do not use xargs We have too many files, and passing them via arguments could cause strange errors on some platforms [1]. Since check-code.py can now take "-" and read file names from stdin, use it instead of xargs to avoid the argv size limit. [1]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-April/096346.html
author Jun Wu <quark@fb.com>
date Thu, 06 Apr 2017 22:10:46 -0700
parents 4804644489cf
children 9fce17c4a7b3
files tests/test-check-code.t
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/tests/test-check-code.t	Thu Apr 06 22:08:23 2017 -0700
+++ b/tests/test-check-code.t	Thu Apr 06 22:10:46 2017 -0700
@@ -8,7 +8,7 @@
 (The writing "no-che?k-code" is for not skipping this file when checking.)
 
   $ hg locate -X contrib/python-zstandard -X hgext/fsmonitor/pywatchman |
-  > sed 's-\\-/-g' | xargs "$check_code" --warnings --per-file=0 || false
+  > sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false
   contrib/perf.py:869:
    >             r.revision(r.node(x))
    don't convert rev to node before passing to revision(nodeorrev)