lazymanifest: don't crash when out of memory (issue5916) stable
authorJosef 'Jeff' Sipek <jeffpc@josefsipek.net>
Wed, 13 Jun 2018 10:41:20 -0400
branchstable
changeset 38302 6caca2a7d37f
parent 38301 d9e87566f879
child 38305 1445b556e9d2
child 38333 03350f5234a4
lazymanifest: don't crash when out of memory (issue5916) self->lines can be NULL if we failed to allocate memory for it.
mercurial/cext/manifest.c
--- a/mercurial/cext/manifest.c	Wed Jun 13 10:37:39 2018 -0400
+++ b/mercurial/cext/manifest.c	Wed Jun 13 10:41:20 2018 -0400
@@ -185,7 +185,7 @@
 {
 	/* free any extra lines we had to allocate */
 	int i;
-	for (i = 0; i < self->numlines; i++) {
+	for (i = 0; self->lines && (i < self->numlines); i++) {
 		if (self->lines[i].from_malloc) {
 			free(self->lines[i].start);
 		}