url: *args argument is a tuple, not a list (found by pylint) stable
authorBenoit Boissinot <benoit.boissinot@ens-lyon.org>
Fri, 19 Feb 2010 02:51:35 +0100
branchstable
changeset 10511 6f61c480f51c
parent 10510 f77f3383c666
child 10512 261cc6b0f15c
child 10513 47838dee7d60
url: *args argument is a tuple, not a list (found by pylint) E1101:514:httpshandler._makeconnection: Instance of 'tuple' has no 'pop' member E1101:516:httpshandler._makeconnection: Instance of 'tuple' has no 'pop' member
mercurial/url.py
--- a/mercurial/url.py	Fri Feb 19 02:23:38 2010 +0100
+++ b/mercurial/url.py	Fri Feb 19 02:51:35 2010 +0100
@@ -510,10 +510,11 @@
             keyfile = None
             certfile = None
 
-            if args: # key_file
-                keyfile = args.pop(0)
-            if args: # cert_file
-                certfile = args.pop(0)
+            if len(args) >= 1: # key_file
+                keyfile = args[0]
+            if len(args) >= 2: # cert_file
+                certfile = args[1]
+            args = args[2:]
 
             # if the user has specified different key/cert files in
             # hgrc, we prefer these