Mercurial > hg
changeset 19793:6fb1b7728719
check-code: new rule to forbid imports of a.b on the same line as other imports
This style of import can trip up 2to3 and cause it to produce invalid
files if one of the imports is supposed to be a relative import. This
prevents that behavior, and in the process exposed a lot of silly
import errors related to the email module.
| author | Augie Fackler <raf@durin42.com> |
|---|---|
| date | Fri, 20 Sep 2013 10:18:09 -0400 |
| parents | efee1f35fcae |
| children | cccc44304b2c |
| files | contrib/check-code.py |
| diffstat | 1 files changed, 3 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/contrib/check-code.py Fri Sep 20 10:16:55 2013 -0400 +++ b/contrib/check-code.py Fri Sep 20 10:18:09 2013 -0400 @@ -162,6 +162,9 @@ "tuple parameter unpacking not available in Python 3+"), (r'lambda\s*\(.*,.*\)', "tuple parameter unpacking not available in Python 3+"), + (r'import (.+,[^.]+\.[^.]+|[^.]+\.[^.]+,)', + '2to3 can\'t always rewrite "import qux, foo.bar", ' + 'use "import foo.bar" on its own line instead.'), (r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"), (r'\breduce\s*\(.*', "reduce is not available in Python 3+"), (r'\.has_key\b', "dict.has_key is not available in Python 3+"),