repoview: keep the branchmap cache for the `served.hidden` view warm
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 04 Apr 2019 13:58:49 +0200
changeset 42127 70b71421fd33
parent 42126 ef0e3cc684b3
child 42128 537a8aeb9977
repoview: keep the branchmap cache for the `served.hidden` view warm For the same reason we want to keep the cache for the `served` view up to date, we want to also keep the `served.hidden` view up to date. If some processes with a readonly access to the repo needs to access it, we better have the cache warm to avoid computing the same data over and over and over. In most case (no secret changesets), the "served" and "served.hidden" set will be identical and no cache will actually have to be updated.
mercurial/localrepo.py
tests/test-rebase-conflicts.t
tests/test-remote-hidden.t
--- a/mercurial/localrepo.py	Mon May 21 17:28:35 2018 +0200
+++ b/mercurial/localrepo.py	Thu Apr 04 13:58:49 2019 +0200
@@ -2107,6 +2107,7 @@
             # accessing the 'ser ved' branchmap should refresh all the others,
             self.ui.debug('updating the branch cache\n')
             self.filtered('served').branchmap()
+            self.filtered('served.hidden').branchmap()
 
         if full:
             unfi = self.unfiltered()
--- a/tests/test-rebase-conflicts.t	Mon May 21 17:28:35 2018 +0200
+++ b/tests/test-rebase-conflicts.t	Thu Apr 04 13:58:49 2019 +0200
@@ -330,6 +330,7 @@
   bundle2-input-bundle: 2 parts total
   updating the branch cache
   invalid branchheads cache (served): tip differs
+  invalid branchheads cache (served.hidden): tip differs
   rebase completed
 
 Test minimization of merge conflicts
--- a/tests/test-remote-hidden.t	Mon May 21 17:28:35 2018 +0200
+++ b/tests/test-remote-hidden.t	Thu Apr 04 13:58:49 2019 +0200
@@ -72,6 +72,20 @@
 Test the feature
 ================
 
+Check cache pre-warm
+--------------------
+
+  $ ls -1 repo-with-hidden/.hg/cache
+  branch2
+  branch2-base
+  branch2-served
+  branch2-served.hidden
+  branch2-visible
+  rbc-names-v1
+  rbc-revs-v1
+  tags2
+  tags2-visible
+
 Check that the `served.hidden` repoview
 ---------------------------------------