Mercurial > hg

changeset 51740:7226f2626fb1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
httppeer: avoid another bad reference before assignment warning This wasn't a problem, because `b''` from the `AttributeError` handler is in `bundle2.bundletypes`, so the following loop and conditional always run at least once. But PyCharm can't figure that out on its own, and it took a little exploring to figure out it wasn't a problem. The usage in `bundle2.writebundle` is to look it up in the map of bundle types, so it will break in a more obvious way in the unlikely event that the empty string is removed from the map in the future.
author Matt Harbison <matt_harbison@yahoo.com>
date Mon, 29 Jul 2024 12:10:08 -0400
parents 78f789a4c8a2
children d748fd2647f8
files mercurial/httppeer.py
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/httppeer.py	Fri Jul 26 21:59:34 2024 -0400
+++ b/mercurial/httppeer.py	Mon Jul 29 12:10:08 2024 -0400
@@ -492,6 +492,9 @@
             # boolean capability. They only support headerless/uncompressed
             # bundles.
             types = [b""]
+
+        type = b""
+
         for x in types:
             if x in bundle2.bundletypes:
                 type = x