Mercurial > hg

changeset 26333:727d57e94cda

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
templater: remove a mutable default argument Mutable default arguments are know to the state of California to cause bugs.
author Pierre-Yves David <pierre-yves.david@fb.com>
date Thu, 24 Sep 2015 01:06:41 -0700
parents 66221730d372
children 0a5a774f5956
files mercurial/templater.py
diffstat 1 files changed, 3 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/templater.py	Thu Sep 24 01:06:10 2015 -0700
+++ b/mercurial/templater.py	Thu Sep 24 01:06:41 2015 -0700
@@ -833,7 +833,7 @@
 
 class templater(object):
 
-    def __init__(self, mapfile, filters=None, defaults={}, cache={},
+    def __init__(self, mapfile, filters=None, defaults=None, cache={},
                  minchunk=1024, maxchunk=65536):
         '''set up template engine.
         mapfile is name of file to read map definitions from.
@@ -841,6 +841,8 @@
         defaults is dict of default map definitions.'''
         if filters is None:
             filters = {}
+        if defaults is None:
+            defaults = {}
         self.mapfile = mapfile or 'template'
         self.cache = cache.copy()
         self.map = {}