Mercurial > hg

changeset 35604:74bec9e74831

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
rust: add TODO about lifetime of program_name variable Per review comment in D1581. Differential Revision: https://phab.mercurial-scm.org/D1847
author Gregory Szorc <gregory.szorc@gmail.com>
date Wed, 10 Jan 2018 19:36:45 -0800
parents 11c86ab69e67
children 45a816361926
files rust/hgcli/src/main.rs
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/rust/hgcli/src/main.rs	Wed Jan 10 19:23:36 2018 -0800
+++ b/rust/hgcli/src/main.rs	Wed Jan 10 19:36:45 2018 -0800
@@ -125,6 +125,9 @@
     // Set program name. The backing memory needs to live for the duration of the
     // interpreter.
     //
+    // TODO consider storing this in a static or associating with lifetime of
+    // the Python interpreter.
+    //
     // Yes, we use the path to the Python interpreter not argv[0] here. The
     // reason is because Python uses the given path to find the location of
     // Python files. Apparently we could define our own ``Py_GetPath()``