context: remove unreliable accessor methods from committablectx
There are two caching routes for (propertycache-ed) "_status" below in
committablectx:
- invoking "status()":
"dirstate.status()" is invoked, and the result of it is cached
into "_status". In this case, any of "listignored", "listclean"
and "listunknown" may be True.
- accessing "_status" directly before "status()":
Own "status()" is invoked, but all of "listignored", "listclean"
and "listunknown" arguments are False, in this case.
"ignored"/"clean"/"unknown" accessor methods of "committablectx" use
corresponded fields of "_status", but these fields aren't reliable,
because these fields are empty when:
- "_status" method is executed before accessors, or
- "status()" is executed with "list*=False" before accessors
In addition to it, these accessors aren't used in the recent Mercurial
implementation. At least, removing them doesn't cause any test
failures.
--- a/mercurial/context.py Wed Dec 31 17:55:43 2014 +0900
+++ b/mercurial/context.py Wed Dec 31 17:55:43 2014 +0900
@@ -1112,12 +1112,6 @@
return self._status.removed
def deleted(self):
return self._status.deleted
- def unknown(self):
- return self._status.unknown
- def ignored(self):
- return self._status.ignored
- def clean(self):
- return self._status.clean
def branch(self):
return encoding.tolocal(self._extra['branch'])
def closesbranch(self):