mq: avoid a silly conversion from binary nodeid to hex
authorMartin von Zweigbergk <martinvonz@google.com>
Thu, 05 Apr 2018 11:33:36 -0700
changeset 37381 76823340a899
parent 37380 c3c76194f0c1
child 37382 de9f9f888900
mq: avoid a silly conversion from binary nodeid to hex We generally deal with binary nodeids in code. In this case the hex nodeid was passed to strip.checksubstate() where it was passed to repo.__getitem__, which of course accepts a binary nodeid. Differential Revision: https://phab.mercurial-scm.org/D3141
hgext/mq.py
--- a/hgext/mq.py	Thu Apr 05 12:36:44 2018 -0700
+++ b/hgext/mq.py	Thu Apr 05 11:33:36 2018 -0700
@@ -1664,7 +1664,7 @@
             cparents = repo.changelog.parents(top)
             patchparent = self.qparents(repo, top)
 
-            inclsubs = checksubstate(repo, hex(patchparent))
+            inclsubs = checksubstate(repo, patchparent)
             if inclsubs:
                 substatestate = repo.dirstate['.hgsubstate']