Mercurial > hg
changeset 35090:79cbf5cc4fb8
templates: reword 'back to filelog' link anchor text
This anchor text is problematic in two ways: first, the "back to" part
assumes that you got to the page showing it via the filelog. This is
not necessarily true, as there are other ways to get to that view
besides the filelog view, such as for example following the history of
lines from a file. Second, it uses "filelog" jargon, which refers to
how each file has its own revlog. This is internal jargon that has no
business being exposed to the end user.
I just reworded this template to improve understanding.
author | Jordi Gutiérrez Hermoso <jordigh@octave.org> |
---|---|
date | Mon, 20 Nov 2017 14:30:54 -0500 |
parents | 69ea10d5b00c |
children | 6a8e85702121 |
files | mercurial/templates/gitweb/filelog.tmpl mercurial/templates/paper/filelog.tmpl tests/test-hgweb-filelog.t |
diffstat | 3 files changed, 6 insertions(+), 6 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/templates/gitweb/filelog.tmpl Sat Nov 18 12:04:08 2017 +0800 +++ b/mercurial/templates/gitweb/filelog.tmpl Mon Nov 20 14:30:54 2017 -0500 @@ -36,7 +36,7 @@ <div class="title" > {file|urlescape}{if(linerange, -' (following lines {linerange}{if(descend, ', descending')} <a href="{url|urlescape}log/{symrev}/{file|urlescape}{sessionvars%urlparameter}">back to filelog</a>)')} +' (following lines {linerange}{if(descend, ', descending')} <a href="{url|urlescape}log/{symrev}/{file|urlescape}{sessionvars%urlparameter}">all revisions for this file</a>)')} </div> <table>
--- a/mercurial/templates/paper/filelog.tmpl Sat Nov 18 12:04:08 2017 +0800 +++ b/mercurial/templates/paper/filelog.tmpl Mon Nov 20 14:30:54 2017 -0500 @@ -48,7 +48,7 @@ log {file|escape} @ {rev}:<a href="{url|urlescape}rev/{node|short}{sessionvars%urlparameter}">{node|short}</a> {alltags} {if(linerange, -' (following lines {linerange}{if(descend, ', descending')} <a href="{url|urlescape}log/{symrev}/{file|urlescape}{sessionvars%urlparameter}">back to filelog</a>)')} +' (following lines {linerange}{if(descend, ', descending')} <a href="{url|urlescape}log/{symrev}/{file|urlescape}{sessionvars%urlparameter}">all revisions for this file</a>)')} </h3> {searchform}
--- a/tests/test-hgweb-filelog.t Sat Nov 18 12:04:08 2017 +0800 +++ b/tests/test-hgweb-filelog.t Mon Nov 20 14:30:54 2017 -0500 @@ -741,7 +741,7 @@ <h3> log c @ 7:<a href="/rev/46c1a66bd8fc">46c1a66bd8fc</a> <span class="phase">draft</span> <span class="branchhead">a-branch</span> <span class="tag">tip</span> - (following lines 1:2 <a href="/log/tip/c">back to filelog</a>) + (following lines 1:2 <a href="/log/tip/c">all revisions for this file</a>) </h3> @@ -861,7 +861,7 @@ <h3> log c @ 7:<a href="/rev/46c1a66bd8fc?revcount=1">46c1a66bd8fc</a> <span class="phase">draft</span> <span class="branchhead">a-branch</span> <span class="tag">tip</span> - (following lines 1:2 <a href="/log/tip/c?revcount=1">back to filelog</a>) + (following lines 1:2 <a href="/log/tip/c?revcount=1">all revisions for this file</a>) </h3> @@ -1380,7 +1380,7 @@ <h3> log c @ 12:<a href="/rev/6e4182052f7b">6e4182052f7b</a> <span class="phase">draft</span> <span class="branchhead">a-branch</span> <span class="tag">tip</span> - (following lines 3:4 <a href="/log/tip/c">back to filelog</a>) + (following lines 3:4 <a href="/log/tip/c">all revisions for this file</a>) </h3> @@ -1637,7 +1637,7 @@ <h3> log c @ 8:<a href="/rev/5c6574614c37">5c6574614c37</a> <span class="phase">draft</span> <span class="branchname">a-branch</span> - (following lines 3:4, descending <a href="/log/8/c">back to filelog</a>) + (following lines 3:4, descending <a href="/log/8/c">all revisions for this file</a>) </h3>