Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
statichttprepo: remove wrong getattr ladder
authorAugie Fackler <raf@durin42.com>
Mon, 18 May 2015 22:40:16 -0400
changeset 25196 7a1af58ab242
parent 25195 472a685a4961
child 25197 6faa7d986a8b
statichttprepo: remove wrong getattr ladder At least as far back as Python 2.6 the .code attribute is always defined, and to the best of my detective skills a .getcode() method has never been a thing.
mercurial/statichttprepo.py file | annotate | diff | comparison | revisions 
--- a/mercurial/statichttprepo.py	Tue May 19 07:17:57 2015 -0500
+++ b/mercurial/statichttprepo.py	Mon May 18 22:40:16 2015 -0400
@@ -32,11 +32,7 @@
         try:
             f = self.opener.open(req)
             data = f.read()
-            # Python 2.6+ defines a getcode() function, and 2.4 and
-            # 2.5 appear to always have an undocumented code attribute
-            # set. If we can't read either of those, fall back to 206
-            # and hope for the best.
-            code = getattr(f, 'getcode', lambda : getattr(f, 'code', 206))()
+            code = f.code
         except urllib2.HTTPError, inst:
             num = inst.code == 404 and errno.ENOENT or None
             raise IOError(num, inst)
Mercurial