Mercurial > hg
changeset 30702:7e4f431206cd
revset: drop TODO comment about sorting issue of fullreposet
The bootstrapping issue was addressed at the parsing phase and we expect
that fullreposet.__and__() fully complies to the smartset API, in which
'self & other' should return a result set in self's order. See also
90455e7bf543.
author | Yuya Nishihara <yuya@tcha.org> |
---|---|
date | Sat, 14 May 2016 20:52:44 +0900 |
parents | 8b1d87243710 |
children | 5c85c93cdd61 |
files | mercurial/revset.py |
diffstat | 1 files changed, 0 insertions(+), 11 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/revset.py Thu Jan 05 22:53:42 2017 +0900 +++ b/mercurial/revset.py Sat May 14 20:52:44 2016 +0900 @@ -3814,17 +3814,6 @@ # object. other = baseset(other - self._hiddenrevs) - # XXX As fullreposet is also used as bootstrap, this is wrong. - # - # With a giveme312() revset returning [3,1,2], this makes - # 'hg log -r "giveme312()"' -> 1, 2, 3 (wrong) - # We cannot just drop it because other usage still need to sort it: - # 'hg log -r "all() and giveme312()"' -> 1, 2, 3 (right) - # - # There is also some faulty revset implementations that rely on it - # (eg: children as of its state in e8075329c5fb) - # - # When we fix the two points above we can move this into the if clause other.sort(reverse=self.isdescending()) return other