convert: Using --dest-type svn crashed, if the source repo used tags. stable
authorDaniel J. Lauk <daniel.lauk@gmail.com>
Wed, 11 Aug 2010 11:46:06 +0200
branchstable
changeset 11778 7e5f5e5858f9
parent 11777 9299b98041e8
child 11779 2b7a75ca6913
convert: Using --dest-type svn crashed, if the source repo used tags. The convert extension requires puttags(self, tags) to return a sequence for a multi-variable assignment. If puttags implicitly returns None, the code will break when trying to un-pack None for assignment.
hgext/convert/subversion.py
--- a/hgext/convert/subversion.py	Wed Aug 11 12:21:27 2010 +0200
+++ b/hgext/convert/subversion.py	Wed Aug 11 11:46:06 2010 +0200
@@ -1158,3 +1158,4 @@
 
     def puttags(self, tags):
         self.ui.warn(_('XXX TAGS NOT IMPLEMENTED YET\n'))
+        return None, None