context.status: remove overriding in workingctx
The workingctx method simply calls the super method. The only effect
it has is that it uses a different default argument for the 'other'
argument. The only in-tree caller is patch.diff, which always passes
an argument to the method, so it should be safe to remove the
overriding. Having the default argument depend on the type seems
rather dangerous anyway.
--- a/mercurial/context.py Mon Oct 20 14:20:43 2014 -0400
+++ b/mercurial/context.py Thu Oct 23 13:43:20 2014 -0700
@@ -1496,14 +1496,6 @@
match.bad = bad
return match
- def status(self, other='.', match=None, listignored=False,
- listclean=False, listunknown=False, listsubrepos=False):
- # yet to be determined: what to do if 'other' is a 'workingctx' or a
- # 'memctx'?
- return super(workingctx, self).status(other, match, listignored,
- listclean, listunknown,
- listsubrepos)
-
class committablefilectx(basefilectx):
"""A committablefilectx provides common functionality for a file context
that wants the ability to commit, e.g. workingfilectx or memfilectx."""