unbundle: add a small comment to clarify the 'check_heads' call
authorPierre-Yves David <pierre-yves.david@ens-lyon.org>
Thu, 02 Feb 2017 10:51:04 +0100
changeset 30868 847f06179f60
parent 30867 aaa751585325
child 30869 887de9516138
unbundle: add a small comment to clarify the 'check_heads' call Bundle2 has its own mechanisms to check for heads (and other) changes, so push using bundle2 is relying on the "check:heads" bundle part of unbundle and the 'check_heads' call is not checking anything. We add a small comment to make this clearer.
mercurial/exchange.py
--- a/mercurial/exchange.py	Thu Feb 02 11:17:36 2017 -0800
+++ b/mercurial/exchange.py	Thu Feb 02 10:51:04 2017 +0100
@@ -1719,6 +1719,8 @@
     if url.startswith('remote:http:') or url.startswith('remote:https:'):
         captureoutput = True
     try:
+        # note: outside bundle1, 'heads' is expected to be empty and this
+        # 'check_heads' call wil be a no-op
         check_heads(repo, heads, 'uploading changes')
         # push can proceed
         if util.safehasattr(cg, 'params'):