revset: use manifest.matches in _follow revset
authorDurham Goode <durham@fb.com>
Fri, 05 Feb 2016 13:30:25 -0800
changeset 28008 86c4cbdaffee
parent 28007 fb92927f9775
child 28009 4a25e91fa55d
revset: use manifest.matches in _follow revset The old _follow revset iterated over every file in the commit and checked if it matched. For repos with large manifests, this could take 500ms. By switching to use manifest.matches() we can take advantage of the fastpaths built in to manifest.py that allows iterating over only the files in the matcher when it's a simple matcher. This brings the time spent down from 500ms to 0ms during simple operations like 'hg log -f file.txt'.
mercurial/revset.py
--- a/mercurial/revset.py	Thu Feb 04 08:34:07 2016 -0800
+++ b/mercurial/revset.py	Fri Feb 05 13:30:25 2016 -0800
@@ -1086,13 +1086,14 @@
         matcher = matchmod.match(repo.root, repo.getcwd(), [x],
                                  ctx=repo[None], default='path')
 
+        files = c.manifest().walk(matcher)
+
         s = set()
-        for fname in c:
-            if matcher(fname):
-                fctx = c[fname]
-                s = s.union(set(c.rev() for c in fctx.ancestors(followfirst)))
-                # include the revision responsible for the most recent version
-                s.add(fctx.introrev())
+        for fname in files:
+            fctx = c[fname]
+            s = s.union(set(c.rev() for c in fctx.ancestors(followfirst)))
+            # include the revision responsible for the most recent version
+            s.add(fctx.introrev())
     else:
         s = _revancestors(repo, baseset([c.rev()]), followfirst)