config: add a .hg/hgrc-not-shared which won't be shared in share-safe mode
Previous patches add a safe mode for sharing repositories which involve sharing
of source requirements and config files.
In certain situations we might need to add a config to source repository which
we does not want to share. For this, we add a `.hg/hgrc-not-shared` which won't
be shared.
This also adds a `--non-shared` flag to `hg config` command to see the
non-shared config.
Differential Revision: https://phab.mercurial-scm.org/D8673
--- a/mercurial/commands.py Fri Sep 18 18:52:38 2020 +0530
+++ b/mercurial/commands.py Wed Jul 01 15:14:59 2020 +0530
@@ -2139,6 +2139,7 @@
None,
_(b'edit shared source repository config (EXPERIMENTAL)'),
),
+ (b'', b'non-shared', None, _(b'edit non shared config (EXPERIMENTAL)')),
(b'g', b'global', None, _(b'edit global config')),
]
+ formatteropts,
@@ -2169,6 +2170,9 @@
.. container:: verbose
+ --non-shared flag is used to edit `.hg/hgrc-not-shared` config file.
+ This file is not shared across shares when in share-safe mode.
+
Template:
The following keywords are supported. See also :hg:`help templates`.
@@ -2186,7 +2190,7 @@
"""
opts = pycompat.byteskwargs(opts)
- editopts = (b'edit', b'local', b'global', b'shared')
+ editopts = (b'edit', b'local', b'global', b'shared', b'non_shared')
if any(opts.get(o) for o in editopts):
cmdutil.check_at_most_one_arg(opts, *editopts[1:])
if opts.get(b'local'):
@@ -2208,6 +2212,8 @@
)
)
paths = [vfsmod.vfs(repo.sharedpath).join(b'hgrc')]
+ elif opts.get(b'non_shared'):
+ paths = [repo.vfs.join(b'hgrc-not-shared')]
else:
paths = rcutil.userrcpath()
--- a/mercurial/dispatch.py Fri Sep 18 18:52:38 2020 +0530
+++ b/mercurial/dispatch.py Wed Jul 01 15:14:59 2020 +0530
@@ -987,6 +987,7 @@
if rcutil.use_repo_hgrc():
_readsharedsourceconfig(lui, path)
lui.readconfig(os.path.join(path, b".hg", b"hgrc"), path)
+ lui.readconfig(os.path.join(path, b".hg", b"hgrc-not-shared"), path)
if rpath:
path = lui.expandpath(rpath)
@@ -994,6 +995,7 @@
if rcutil.use_repo_hgrc():
_readsharedsourceconfig(lui, path)
lui.readconfig(os.path.join(path, b".hg", b"hgrc"), path)
+ lui.readconfig(os.path.join(path, b".hg", b"hgrc-not-shared"), path)
return path, lui
--- a/mercurial/localrepo.py Fri Sep 18 18:52:38 2020 +0530
+++ b/mercurial/localrepo.py Wed Jul 01 15:14:59 2020 +0530
@@ -715,18 +715,28 @@
if not rcutil.use_repo_hgrc():
return False
+ ret = False
# first load config from shared source if we has to
if requirementsmod.SHARESAFE_REQUIREMENT in requirements and sharedvfs:
try:
ui.readconfig(sharedvfs.join(b'hgrc'), root=sharedvfs.base)
+ ret = True
except IOError:
pass
try:
ui.readconfig(hgvfs.join(b'hgrc'), root=wdirvfs.base)
- return True
+ ret = True
except IOError:
- return False
+ pass
+
+ try:
+ ui.readconfig(hgvfs.join(b'hgrc-not-shared'), root=wdirvfs.base)
+ ret = True
+ except IOError:
+ pass
+
+ return ret
def afterhgrcload(ui, wdirvfs, hgvfs, requirements):
--- a/tests/test-completion.t Fri Sep 18 18:52:38 2020 +0530
+++ b/tests/test-completion.t Wed Jul 01 15:14:59 2020 +0530
@@ -259,7 +259,7 @@
cat: output, rev, decode, include, exclude, template
clone: noupdate, updaterev, rev, branch, pull, uncompressed, stream, ssh, remotecmd, insecure
commit: addremove, close-branch, amend, secret, edit, force-close-branch, interactive, include, exclude, message, logfile, date, user, subrepos
- config: untrusted, edit, local, shared, global, template
+ config: untrusted, edit, local, shared, non-shared, global, template
continue: dry-run
copy: forget, after, at-rev, force, include, exclude, dry-run
debugancestor:
--- a/tests/test-share-safe.t Fri Sep 18 18:52:38 2020 +0530
+++ b/tests/test-share-safe.t Wed Jul 01 15:14:59 2020 +0530
@@ -253,6 +253,25 @@
date: Thu Jan 01 00:00:00 1970 +0000
summary: added c
+
+Testing that nonsharedrc is loaded for source and not shared
+
+ $ cd ../source
+ $ touch .hg/hgrc-not-shared
+ $ echo "[ui]" >> .hg/hgrc-not-shared
+ $ echo "traceback=true" >> .hg/hgrc-not-shared
+
+ $ hg showconfig ui.traceback
+ true
+
+ $ HGEDITOR=cat hg config --non-shared
+ [ui]
+ traceback=true
+
+ $ cd ../shared1
+ $ hg showconfig ui.traceback
+ [1]
+
Unsharing works
$ hg unshare