bundlerepo: fix closing and docstring of getremotechanges
authorPeter Arrenbrecht <peter.arrenbrecht@gmail.com>
Wed, 04 May 2011 20:14:30 +0200
changeset 14190 8aab5a82685f
parent 14189 328422b0380d
child 14191 e1c34ce39fae
bundlerepo: fix closing and docstring of getremotechanges I did not in fact implement what I documented about closing of the original repo. And there was a bit of leftover from an older version of the API.
mercurial/bundlerepo.py
--- a/mercurial/bundlerepo.py	Wed May 04 10:43:47 2011 -0500
+++ b/mercurial/bundlerepo.py	Wed May 04 20:14:30 2011 +0200
@@ -295,7 +295,8 @@
     "onlyheads" restricts the returned changes to those reachable from the
       specified heads.
     "bundlename", if given, stores the bundle to this file path permanently;
-      the returned "bundle" will be None.
+      otherwise it's stored to a temp file and gets deleted again when you call
+      the returned "cleanupfn".
     "force" indicates whether to proceed on unrelated repos.
 
     Returns a tuple (local, csets, cleanupfn):
@@ -348,7 +349,7 @@
             bundlerepo.close()
         if bundle:
             os.unlink(bundle)
-        localrepo.close()
+        other.close()
 
     return (localrepo, csets, cleanup)