strip: use context manager for locking and transaction in stripcmd()
authorMartin von Zweigbergk <martinvonz@google.com>
Mon, 19 Jun 2017 11:20:29 -0700
changeset 32920 8dbcb66ac160
parent 32919 daceeed34ad2
child 32921 5694311db6ed
strip: use context manager for locking and transaction in stripcmd()
hgext/strip.py
--- a/hgext/strip.py	Mon Jun 19 11:17:31 2017 -0700
+++ b/hgext/strip.py	Mon Jun 19 11:20:29 2017 -0700
@@ -156,18 +156,12 @@
                     rsrevs = repair.stripbmrevset(repo, marks[0])
                     revs.update(set(rsrevs))
             if not revs:
-                lock = tr = None
-                try:
-                    lock = repo.lock()
-                    tr = repo.transaction('bookmark')
+                with repo.lock(), repo.transaction('bookmark') as tr:
                     for bookmark in bookmarks:
                         del repomarks[bookmark]
                     repomarks.recordchange(tr)
-                    tr.close()
-                    for bookmark in sorted(bookmarks):
-                        ui.write(_("bookmark '%s' deleted\n") % bookmark)
-                finally:
-                    release(lock, tr)
+                for bookmark in sorted(bookmarks):
+                    ui.write(_("bookmark '%s' deleted\n") % bookmark)
 
         if not revs:
             raise error.Abort(_('empty revision set'))