context: raise ProgrammingError on repo['my-tag']
authorMartin von Zweigbergk <martinvonz@google.com>
Fri, 06 Jul 2018 16:45:44 -0700
changeset 38589 91618801d5c3
parent 38588 1c93e0237a24
child 38590 f068495a1c28
context: raise ProgrammingError on repo['my-tag'] We had an internal extension that I had failed to migrate off of the deprecated API and its "'my-tag' in repo" check just started returning False. It took a while to figure out that that was what was happening. This patch would have helped. Differential Revision: https://phab.mercurial-scm.org/D3895
mercurial/context.py
--- a/mercurial/context.py	Fri Jul 06 21:49:25 2018 +0900
+++ b/mercurial/context.py	Fri Jul 06 16:45:44 2018 -0700
@@ -432,6 +432,10 @@
                     raise
                 except (TypeError, LookupError):
                     pass
+            else:
+                raise error.ProgrammingError(
+                        "unsupported changeid '%s' of type %s" %
+                        (changeid, type(changeid)))
 
             # lookup failed
         except (error.FilteredIndexError, error.FilteredLookupError):