patch: include newline at EOF in help text for interactive patch
authorMartin von Zweigbergk <martinvonz@google.com>
Tue, 12 Mar 2019 14:58:35 -0700
changeset 41986 95e4ae86329f
parent 41985 b1bc6e5f5249
child 41987 c1d83d916e85
patch: include newline at EOF in help text for interactive patch The lack of a newline means that some "editors" that are useful in tests, such as `echo "+new line" >> "$1"` don't work. It's obviously easy to work around it, but newline at EOF seems like a good practice anyway. Differential Revision: https://phab.mercurial-scm.org/D6124
mercurial/patch.py
--- a/mercurial/patch.py	Tue Mar 19 16:36:59 2019 +0300
+++ b/mercurial/patch.py	Tue Mar 12 14:58:35 2019 -0700
@@ -1117,7 +1117,8 @@
                     f = util.nativeeolwriter(os.fdopen(patchfd, r'wb'))
                     chunk.header.write(f)
                     chunk.write(f)
-                    f.write('\n'.join(['# ' + i for i in phelp.splitlines()]))
+                    f.write(''.join(['# ' + i + '\n'
+                                     for i in phelp.splitlines()]))
                     f.close()
                     # Start the editor and wait for it to complete
                     editor = ui.geteditor()