zeroconf: fix boolean return value
authorRaphaël Gomès <rgomes@octobus.net>
Thu, 18 Jul 2024 12:02:01 +0200
changeset 51701 97d013f48cae
parent 51700 7f0cb9ee0534
child 51702 b0a4de6c14f8
zeroconf: fix boolean return value This was (wrongly) flagged by Pytype as being undefined since it doesn't seem to understand `try` blocks. However, the caller is expecting a boolean and the fix to appease Pytype is simple, so we do both.
hgext/zeroconf/Zeroconf.py
--- a/hgext/zeroconf/Zeroconf.py	Tue Jul 23 10:02:46 2024 +0200
+++ b/hgext/zeroconf/Zeroconf.py	Thu Jul 18 12:02:01 2024 +0200
@@ -1307,6 +1307,7 @@
         delay = _LISTENER_TIME
         next = now + delay
         last = now + timeout
+        result = False
         try:
             zeroconf.addListener(
                 self, DNSQuestion(self.name, _TYPE_ANY, _CLASS_IN)
@@ -1352,7 +1353,7 @@
 
                 zeroconf.wait(min(next, last) - now)
                 now = currentTimeMillis()
-            result = 1
+            result = True
         finally:
             zeroconf.removeListener(self)