bugzilla: rename filter_unknown_bug_ids to reflect its actual purpose.
authorJim Hague <jim.hague@acm.org>
Wed, 30 Mar 2011 09:49:45 +0100
changeset 13798 9c9fa78f4e2d
parent 13797 16d5e80876de
child 13799 d04fc5582772
bugzilla: rename filter_unknown_bug_ids to reflect its actual purpose. The method really removes from the list of bugs any that already have comment text referencing the changeset in question. Rename it to filter_cset_known_bug_ids().
hgext/bugzilla.py
--- a/hgext/bugzilla.py	Tue Mar 29 19:20:28 2011 +0200
+++ b/hgext/bugzilla.py	Wed Mar 30 09:49:45 2011 +0100
@@ -194,7 +194,7 @@
         self.run('select bug_id from bugs where bug_id in %s' % buglist(ids))
         return sorted([c[0] for c in self.cursor.fetchall()])
 
-    def filter_unknown_bug_ids(self, node, ids):
+    def filter_cset_known_bug_ids(self, node, ids):
         '''filter bug ids from list that already refer to this changeset.'''
 
         self.run('''select bug_id from longdescs where
@@ -376,7 +376,7 @@
         if ids:
             ids = self.filter_real_bug_ids(ids)
         if ids:
-            ids = self.filter_unknown_bug_ids(ctx.node(), ids)
+            ids = self.filter_cset_known_bug_ids(ctx.node(), ids)
         return ids
 
     def update(self, bugid, ctx):